-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Note a more efficient computation of the auth difference. #1119
Note a more efficient computation of the auth difference. #1119
Conversation
chain for each state *S*<sub>*i*</sub>, and then discarding the events | ||
belonging to each full auth chain. In symbols: if *F*(*S*) is the full auth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this changes the meaning. "Discarding the events belonging to each full auth chain" would mean we would be left with only the event not in any of the full auth chains.
Possibly we want "taking each event which is missing from one or more full auth chains".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about something completely different:
For each state Si, compute its full auth chain. The auth difference is the set of events which belong to some, but not all, of these full auth chains.
I'm trying to avoid "the auth difference is calculated by doing X" in favour of "the auth difference is Y.
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Travis Ralston <travpc@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks!
This can be computed more efficiently as | ||
*F*(*C*) - ∩<sub>*i*</sub> *F*(*S*<sub>*i* - *C*</sub>) , | ||
where *C* is the conflicted state set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erikjohnston and I believe this sentence to be incorrect. The other changes are fine as clarifications however.
Closes #1118; see that issue for rationale.
Preview: https://pr1119--matrix-spec-previews.netlify.app