Spec omit_members for /v2/send_join
#1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we are extending v2, but not v1.
|
I haven't written much about how this is meant to be used, since faster-joins are still somewhat in development, and that's really the topic of MSC3902. It's really just meant to lay down the mechanism on which faster-joins are based. |
This was referenced Jan 8, 2023
This was referenced Jan 12, 2023
DMRobertson
added a commit
to matrix-org/gomatrixserverlib
that referenced
this pull request
Jan 13, 2023
I haven't made any effort to maintain backwards compatibility (unlike in matrix-org/synapse#14832). I'm happy to do so if needed, but might need some guidance. Synapse issue: matrix-org/synapse#14828 Synapse PR: matrix-org/synapse#14832 Complement PR: matrix-org/complement#583 GMSL PR: #350 MSC: matrix-org/matrix-spec-proposals#3706 Spec diff: matrix-org/matrix-spec#1393 ### Pull Request Checklist * [x] Pull request includes a [sign off](https://github.com/matrix-org/dendrite/blob/master/docs/CONTRIBUTING.md#sign-off) Signed-off-by: `David Robertson <davidr@element.io>`
clokep
pushed a commit
to clokep/matrix-spec
that referenced
this pull request
May 3, 2023
Per MSC3706
11 tasks
agschaid
reviewed
Oct 16, 2024
There was a problem hiding this comment.
did you forget to change the example of the sendJoinV1 response?
The event should be gone, I suppose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per MSC3706
Preview: https://pr1393--matrix-spec-previews.netlify.app