Clarify signatures upload endpoint #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoadragon453
approved these changes
May 2, 2023
There was a problem hiding this comment.
This text change looks great, thank you! While you're here, could you also fix the Request body parameters section just below? Looking at https://pr1495--matrix-spec-previews.netlify.app/client-server-api/#post_matrixclientv3keyssignaturesupload, I currently see:
The contents under "Request" -> "Request body" are missing.
4 tasks
I think that's somewhat expected, and a result of the fact that the top-level key is a user ID rather than a fixed string. #1162 is related, but sadly stuck. I think we should merge this as-is and consider the poor formatting of requests like this a separate problem. |
47 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://pr1495--matrix-spec-previews.netlify.app