-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use auto table-layout on desktop #1601
Conversation
* Thus, we override the "display" property here. This may no longer be necessary once | ||
* Docsy updates to Bootstrap v5+: https://github.com/google/docsy/issues/470. | ||
* For more details, see | ||
* https://github.com/matrix-org/matrix-spec/pull/1295/files#r1010759688 */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should update our fork of docsy now that google/docsy#470 is closed...
Anyway, I guess that is a separate problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please add a changelog and sign-off.
1e19200
to
0d201e8
Compare
Just signed-off the commit. I'd be happy to add a changelog entry but none of the allowed changelog entry types fits this PR (new, feature, clarification, breaking, deprecation). I'd classify this as "style" but I'm assuming |
Thanks! You could make it a |
CONTRIBUTING.rst defines
That really sounds like a change to the text of the spec ... so I don't really want to classify it as "clarification" since I'd consider that as misleading. |
I mean you're right, and #1369 mentions the fact that it's not a great match. But it's what we use for now. Compare https://spec.matrix.org/v1.7/changelog/#internal-changestooling for where we've done this in the past. None of those are really changes to the spec. |
Signed-off-by: Martin Fischer <martin@push-f.com>
0d201e8
to
011a511
Compare
Fair enough ... added the newsfragment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
(Aside: it's fine in this case, because the changes are relatively small, but please don't force-push after a review: it makes it hard to see what has changed since the previous review. We can clean up the commit history when we merge the PR.)
@@ -0,0 +1 @@ | |||
Improve the layout of tables on desktop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve the layout of tables on desktop. | |
Improve the layout of tables on desktop displays. Contributed by @not-my-profile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like my work being attributed to my GitHub username :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry. I can remove this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you prefer an alternative attribution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah: Martin Fischer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: f5035b8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks <3
Per request at #1601 (comment)
On desktop the tables in the specification currently have quite awkward column widths, making them harder to read.
While the fixed table-layout does have an advantage on mobile since it avoids unnecessary horizontal scrolling in the tables, we can just use it on narrow browser widths via a media query, while still using the more readable auto layout on desktop.
Preview: https://pr1601--matrix-spec-previews.netlify.app