Document case of knock->join membership transition #1709
Conversation
|
The table in https://github.com/matrix-org/matrix-spec/blob/main/data/event-schemas/schema/m.room.member.yaml will need updating as well. Tangentially related: what happens to knocking users when a room changes its |
This is a great point. According to the auth rules, you can go straight to |
| </mxGeometry> | ||
| </mxCell> | ||
| <mxCell id="q5SATBPCpZFuv_SF1K4v-1" value="/join if join_rules<br>knock_restricted<br>and using a <br>restricted join" style="edgeStyle=orthogonalEdgeStyle;rounded=0;orthogonalLoop=1;jettySize=auto;html=1;exitX=0.25;exitY=0;exitDx=0;exitDy=0;entryX=0;entryY=0.25;entryDx=0;entryDy=0;jumpStyle=arc;" edge="1" parent="1" source="P05zALBlSnZwpnZ5Cu9t-24" target="P05zALBlSnZwpnZ5Cu9t-2"> |
There was a problem hiding this comment.
/join if join_rules knock_restricted and using a restricted join
I assume by "restricted join", we mean "a join satisfying one of the conditions for restricted rooms"?
The transition is also permitted if the join_rules are restricted (and the restriction conditions are satisfied), or as @Xiretza points out, if the join rules are public.
Indeed, I think the rules for the knock -> join transition are identical to those for the leave -> join and external -> join transitions (which makes sense intuitively, and makes sense because neither leave nor knock are specifically mentioned in auth rule 4.3, which covers the transition to join generally). So, can we just make it use the same label "/join if allowed by join_rules" ?
|
The |
|
@turt2live are you still working on this? |
|
I forgot this existed, sorry. I'd suggest someone else takes it over (if needed). |
This adds a line from the
knockblock to thejoinblock, as the transition is legal inknock_restrictedrooms when using restricted joins.See auth rule 4.3.5.
Preview: https://pr1709--matrix-spec-previews.netlify.app