Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unecessary allOfs #1797

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Clean up unecessary allOfs #1797

merged 2 commits into from
Apr 23, 2024

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Apr 23, 2024

Most of them were unnecessary to begin with. A few of them were necessary given the definition, but it turns out that the fields were duplicates to the ones in the $ref.

Preview: https://pr1797--matrix-spec-previews.netlify.app

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh requested a review from a team as a code owner April 23, 2024 15:41
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. I think an earlier version of our tooling only supported $ref within an allOf.

@richvdh richvdh merged commit 26ce392 into matrix-org:main Apr 23, 2024
12 checks passed
@zecakeh zecakeh deleted the cleanup-allof branch April 23, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants