Clarify that lazy_load_members in timeline isn't respected in /sync #2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zecakeh
reviewed
Nov 21, 2024
| @@ -28,15 +28,17 @@ allOf: | |||
| description: |- | |||
| If `true`, enables lazy-loading of membership events. See | |||
| [Lazy-loading room members](/client-server-api/#lazy-loading-room-members) | |||
| for more information. Defaults to `false`. | |||
| for more information. Defaults to `false`. Only applies to the `/messages` | |||
There was a problem hiding this comment.
It should also apply to the /context endpoint, as listed in the "lazy-loading room members" section. I believe it would be better to only list exceptions here.
|
Are we sure this isn't a synapse bug? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one caught me out today, clarify that sync only uses
lazy_load_membersfromstate.https://github.com/element-hq/synapse/blob/develop/synapse/api/filtering.py#L240-L241
Pull Request Checklist
Signed-off-by: Brad Murray brad@beeper.com
Preview: https://pr2010--matrix-spec-previews.netlify.app