Find new X expressions when looking for translation functions
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for matrix-org/matrix-react-sdk#10440 ``` new UserFriendlyError("This email address is already in use" , { cause: err }); ```
MadLittleMods
changed the title
new X expressions when looking for translation functions
t3chguy
approved these changes
Mar 24, 2023
|
Thanks for the review @t3chguy! How are releases managed in this project? |
Thanks for pointing it out! It looks like a manual CI run. I've done Run workflow -> minor which created https://github.com/matrix-org/matrix-web-i18n/actions/runs/4535122363 after a bit which made |
MadLittleMods
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Mar 27, 2023
Includes changes to find `new UserFriendlyError`, see matrix-org/matrix-web-i18n#6
t3chguy
pushed a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Mar 31, 2023
* Introduce UserFriendlyError * Replace newTranslatableError with UserFriendlyError * Remove ITranslatableError * Fix up some strict lints * Document when we/why we can remove * Update matrix-web-i18n Includes changes to find `new UserFriendlyError`, see matrix-org/matrix-web-i18n#6 * Include room ID in error * Translate fallback error * Translate better * Update i18n strings * Better re-use * Minor comment fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find
new Xexpressions when looking for translation functionsNeeded for matrix-org/matrix-react-sdk#10440
Dev notes