Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect type declaration in check_username_for_spam #250

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Fix incorrect type declaration in check_username_for_spam #250

merged 1 commit into from
Mar 18, 2022

Conversation

Gnuxie
Copy link
Contributor

@Gnuxie Gnuxie commented Mar 18, 2022

@Gnuxie Gnuxie requested review from Yoric and squahtx March 18, 2022 13:15
@Gnuxie Gnuxie self-assigned this Mar 18, 2022
@squahtx
Copy link

squahtx commented Mar 18, 2022

Looks good to me!

It might be worth setting up some python linting at some point in the future. In Synapse we use isort to keep imports in a certain order and black for formatting.

EDIT: there's a minor typo in the commit message: s/decleration/declaration/

@Gnuxie Gnuxie force-pushed the gnuxie/check-username-for-spam branch from 019d6f6 to 1843260 Compare March 18, 2022 16:58
@Gnuxie Gnuxie mentioned this pull request Mar 18, 2022
Open
@Gnuxie Gnuxie changed the title Fix incorrect type decleration in check_username_for_spam Fix incorrect type declaration in check_username_for_spam Mar 18, 2022
@Gnuxie Gnuxie merged commit 814e528 into main Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yoric Yoric Yoric approved these changes

@squahtx squahtx Awaiting requested review from squahtx

Assignees

@Gnuxie Gnuxie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gnuxie @squahtx @Yoric