Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report log level. #17

Merged
merged 3 commits into from
Oct 22, 2020
Merged

Report log level. #17

merged 3 commits into from
Oct 22, 2020

Conversation

clokep
Copy link
Member

@clokep clokep commented Oct 8, 2020

This matches the changes from matrix-org/synapse#8477.

@clokep
Copy link
Member Author

clokep commented Oct 8, 2020

Wasn't sure who to request review from, hopefully one of you is correct. 😄

Copy link
Contributor

@neilisfragile neilisfragile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to merge as is.

While you are in the area could you also check if other datapoints are transmitted and not currently handled?

For instance I think count_monthly_users is an example.

For double points, if you could also add aggregation support for count_monthly_users that would be extremely helpful. https://github.com/matrix-org/panopticon/blob/master/scripts/aggregate.py it should be quite easy to crib.

No need to aggregate log level though.

@clokep clokep removed the request for review from michaelkaye October 14, 2020 12:06
@clokep
Copy link
Member Author

clokep commented Oct 14, 2020

While you are in the area could you also check if other datapoints are transmitted and not currently handled?

For instance I think count_monthly_users is an example.

I cross-referenced and it seems monthly_active_users is not handled, I assume this is the same thing!

I'll add that and take a look at aggregating it.

@clokep
Copy link
Member Author

clokep commented Oct 14, 2020

@neilisfragile I think I made the proper changes, the docker-tests.sh pass, but I'm unsure how/if there's anyway to test the aggregation.

Copy link
Contributor

@neilisfragile neilisfragile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm afraid that the testing coverage is pretty poor though changes are generally rare - the aggregate table will also need the mau column adding manually.

@clokep clokep merged commit 7a232d2 into master Oct 22, 2020
@clokep clokep deleted the clokep/log-level branch October 22, 2020 14:33
@clokep
Copy link
Member Author

clokep commented Oct 23, 2020

This was deployed in release v0.1.3 and I confirmed that both new columns are having data added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants