Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunked downloads #149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codemonium
Copy link
Contributor

@codemonium codemonium commented Jan 4, 2023

Before this change, whenever the user would download an attachment, the client (Pantalaimon) would store all the data in memory while processing it. This causes significant memory usage spikes when downloading multiple large files at once. The high memory usage is a major problem when running Pantalaimon in a memory-constrained setting.

This change uses new matrix-nio functions to download and decrypt the attachments in chunks, which resolves the memory usage issues.

See also matrix-nio/matrix-nio#373

Before this change, whenever the user would download an attachment, the
client (Pantalaimon) would store all the data in memory while processing
it. This causes significant memory usage spikes when downloading
multiple large files at once. The high memory usage is a major problem
when running Pantalaimon in a memory-constrained setting.

This change uses new matrix-nio functions to download and decrypt the
attachments in chunks, which resolves the memory usage issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant