Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace dasbus with Gio since it gets rid of depencency #180

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

chookity-pokk
Copy link
Collaborator

Gets rid of dasbus in preference of the one in Gio since I couldn't get the threading to work properly in dasbus and this gets rid of a dependency 🎉.

@chookity-pokk
Copy link
Collaborator Author

Fixes #177

@Icy-Thought
Copy link
Contributor

Icy-Thought commented Oct 30, 2024

Built and tested on NixOS. Works as expected! Thanks for the PR!
Also, I'd like to apologize for not doing it myself, as I'd said I would.

EDIT: I lied. I just noticed that pantalaimon complains when you try to use panctl.

panctl> list-devices
Error: the following arguments are required: pan_user, user_id (see help)

Unhandled exception in event loop:
  File "/nix/store/jn8sq9pig4czrl8cmcpq05b0v0dm37na-python3.12-prompt-toolkit-3.0.47/lib/python3.12/site-packages/prompt_toolkit/buffer.py", line 1923, in new_coroutine
    await coroutine(*a, **kw)
  File "/nix/store/jn8sq9pig4czrl8cmcpq05b0v0dm37na-python3.12-prompt-toolkit-3.0.47/lib/python3.12/site-packages/prompt_toolkit/buffer.py", line 1740, in async_completer
    async for completion in async_generator:
  File "/nix/store/jn8sq9pig4czrl8cmcpq05b0v0dm37na-python3.12-prompt-toolkit-3.0.47/lib/python3.12/site-packages/prompt_toolkit/completion/base.py", line 310, in get_completions_async
    async for completion in completer.get_completions_async(
  File "/nix/store/jn8sq9pig4czrl8cmcpq05b0v0dm37na-python3.12-prompt-toolkit-3.0.47/lib/python3.12/site-packages/prompt_toolkit/completion/base.py", line 186, in get_completions_async
    for item in self.get_completions(document, complete_event):
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/i2zppd88id8gwks5jrd1v72yz5r7av8z-pantalaimon-0.10.5/lib/python3.12/site-packages/pantalaimon/panctl.py", line 192, in complete_pan_users
    servers = self.ctl.ListServers()
              ^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/44n7v64jbkar47zk7nm8mbx36cqxh7y9-python3.12-pygobject-3.48.2/lib/python3.12/site-packages/gi/overrides/Gio.py", line 349, in __call__
    result = self.dbus_proxy.call_sync(self.method_name, arg_variant,
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Exception g-dbus-error-quark: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name org.pantalaimon1 was not provided by any .service files (2)
Press ENTER to continue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants