Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add options to not sync on startup and timeout the sync after some time #84

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Half-Shot
Copy link
Contributor

Fixes #83

This PR is to facilitate the bridge work going on, and is something for me to get back to ASAP

@Half-Shot Half-Shot self-assigned this Jan 14, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2021

Codecov Report

Merging #84 (e590cc9) into master (a7286df) will increase coverage by 0.15%.
The diff coverage is 39.53%.

❗ Current head e590cc9 differs from pull request most recent head 7312e57. Consider uploading reports for the commit 7312e57 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   28.19%   28.34%   +0.15%     
==========================================
  Files          10       10              
  Lines        2334     2374      +40     
==========================================
+ Hits          658      673      +15     
- Misses       1676     1701      +25     
Impacted Files Coverage Δ
pantalaimon/daemon.py 23.47% <20.00%> (+<0.01%) ⬆️
pantalaimon/client.py 32.91% <36.00%> (-0.13%) ⬇️
pantalaimon/config.py 38.83% <50.00%> (+0.69%) ⬆️
pantalaimon/store.py 79.15% <57.14%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3be7be...7312e57. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop syncing in the background after a reasonable timeout if the client doesn't request /sync
2 participants