Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI to publish official container #117

Merged

Conversation

thefirstofthe300
Copy link
Contributor

@thefirstofthe300 thefirstofthe300 commented May 14, 2023

Adds a Github Actions workflow to publish containers on merges to main and when new tags are pushed.

As part of the change, cargo will now use the release when building the published containers, but default to the dev profile when building the container locally.

To fully configure this CI pipeline, there will need to be two Github Actions secrets added:

  • DOCKERHUB_USERNAME set to matrixdotorg
  • DOCKERHUB_TOKEN set to an API key capable of pushing to a matrixdotorg/rust-synapse-compress-state Docker Hub repository

The CI will automatically start pushing to both GHCR and Docker Hub.

I've validated the CI works on my own fork of this repo. See this job for a full run.

Signed-off-by: Danny Seymour danny@seymour.family

Adds a Github Actions workflow to publish containers on merges to main
and when new tags are pushed.

As part of the change, cargo will now use the release when building the
published containers, but default to the dev profile when building the
container locally.
@thefirstofthe300 thefirstofthe300 requested a review from a team as a code owner May 14, 2023 22:59
@clokep clokep changed the title feat: add CI to publish official container Add CI to publish official container May 17, 2023
Copy link
Contributor

@reivilibre reivilibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me; please would you be able to create a sign-off as though this was Synapse?

See https://matrix-org.github.io/synapse/latest/development/contributing_guide.html?highlight=sign-off#sign-off

@thefirstofthe300
Copy link
Contributor Author

@reivilibre That doc said I could add the sign-off to the PR so I went ahead and edited the initial PR comment. Let me know if I need to do anything further.

@reivilibre reivilibre self-requested a review June 2, 2023 19:14
Copy link
Contributor

@reivilibre reivilibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@reivilibre reivilibre merged commit 8fca8ad into matrix-org:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants