Update dependencies and improve pyo3 #147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update all dependencies so that `cargo outdated -R` is satisfied. - Use declarative pyo3 modules. - The docs and the code disagreed on whether the auto compressor entry point is named `compress_largest_rooms`, `compress_state_events_table` or `compress_chunks_of_database`. Rename the entry point to `run_compression`, matching the manual compressor, and fix the docs. Leave `compress_largest_rooms` as another entry point to avoid breaking existing code. - Provide a default for `default_levels`. - Use `&str` instead of `String` in Python signatures where it simplifies the code or is necessary to include the default in the text signature. - Release the GIL while running the manual compressor. - Use `map_err` to simplify error conversion a bit. Signed-off-by: Jan Alexander Steffens (heftig) <heftig@archlinux.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all dependencies so that
cargo outdated -Ris satisfied.Use declarative pyo3 modules.
The docs and the code disagreed on whether the auto compressor entry point is named
compress_largest_rooms,compress_state_events_tableorcompress_chunks_of_database.Rename the entry point to
run_compression, matching the manual compressor, and fix the docs. Leavecompress_largest_roomsas another entry point to avoid breaking existing code.Provide a default for
default_levels.Use
&strinstead ofStringin Python signatures where it simplifies the code or is necessary to include the default in the text signature.Release the GIL while running the manual compressor.
Use
map_errto simplify error conversion a bit.