Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce mutex contention on callbacks #311

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Reduce mutex contention on callbacks #311

merged 1 commit into from
Sep 21, 2023

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Sep 21, 2023

Don't keep pollerMu held for longer than we need to.

@kegsay kegsay added bug Something isn't working poller labels Sep 21, 2023
@kegsay kegsay requested a review from DMRobertson September 21, 2023 16:17
@DMRobertson
Copy link
Contributor

I'd like to read through the rest of the places that acquire that mutex---I bet there are other places we can do better.

DMRobertson
DMRobertson approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy if CI is.

@kegsay kegsay merged commit 6fe9b18 into main Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMRobertson DMRobertson DMRobertson approved these changes

Assignees
No one assigned
Labels
bug Something isn't working poller
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kegsay @DMRobertson