Fix invite acceptance over federation #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think the explicit import of |
MatMaul
approved these changes
May 16, 2023
squahtx
reviewed
May 16, 2023
| target=target, | ||
| room_id=room_id, | ||
| new_membership=new_membership, | ||
| ) |
There was a problem hiding this comment.
There is a break on line 191 (still within the while loop) - would it make more sense to move it to line 183?
There was a problem hiding this comment.
I misread the code, sorry!
The if condition can be omitted if the break is moved to line 183, but I don't feel strongly about this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a race condition which caused accepting invites over federation to fail. It adds a function which runs as a background process which retries the
update_room_membershipcall several times if an exception is raised byupdate_room_membership. Fixes #12.The associated PR in Synapse is matrix-org/synapse#15577.