-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First cut of the module #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I assume you've tested it works, so the comment is really just a question about how it works (with perhaps a point that it might be nice to document it readily, as it seems not immediately obvious).
I've rewritten a bit of the module so it now uses the callback to matrix-org/synapse#12302, and binds assocs when they're verified on the HS rather than only on registration.
|
Code has changed quite a bit since the review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine otherwise, I think!
Co-authored-by: reivilibre <olivier@librepush.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to require reformatting, but AST-wise this is fine
Edit: actually it looks like black
might be broken? Hrmph.
…sydent into babolivier/init
This work is happening in the context of the Tchap mainlining. In Tchap, when a user is registered (which always requires an email to be set), the email is automatically bound to a Sydent instance using the internal API (so that their email can be looked up immediately, and without having to go through additional manual validation).
This module implements this behaviour by using the
on_user_registration
account validity callback, as well as a module API method added in matrix-org/synapse#12195.The CI is expecting to fail since matrix-org/synapse#12195 hasn't made it into mainline CI yet, but it's all passing locally.