WARNING - Starting db txn ... from sentinel context

[michaelkaye]

The code is currently logging this repeatedly:

synapse.storage.database - WARNING - - Starting db txn 'get_replication_hosts' from sentinel context
synapse.storage.database - WARNING - - Starting db connection from sentinel context: metrics will not be
synapse.storage.database - WARNING - - Starting db txn 'get_latest_profile_replication_batch' from sentinel context
synapse.storage.database - WARNING - - Starting db connection from sentinel context: metrics will not be

Doesn't seem to cause any issues but the metrics for these transactions are not being reported to prometheus and WARNING's are polluting the log files. Would be good to move them to the right context somehow.

[babolivier]

@anoadragon453 says:

Mm, yes those should probably go in the sql_logger

[clokep]

Doesn't this point to an issue which should be fixed to get the metrics working for those function calls?

[richvdh]

yes it does! hiding the warnings is the wrong solution.

[anoadragon453]

Some log lines have been moved into their proper places as part of matrix-org/synapse#7952, however as explained by others, the ones mentioned here are complaining about actual issues and have not been moved.

So this issue remains open while we figure out the cause of those.