Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Fix buggy condition in account validity handler #28

Merged
merged 3 commits into from
Mar 16, 2020

Conversation

babolivier
Copy link
Contributor

Otherwise renewal emails would be sent even if enabled is set to false in the account validity config.

@babolivier babolivier requested a review from a team March 13, 2020 10:06
@babolivier
Copy link
Contributor Author

CI is failing because it's trying to get the latest version of signedjson (1.1.0), which removes a function we need. Given this should be fixed by the upcoming mainline merge, I'm going to pin this dependency to 1.0.0 for now.

Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anoadragon453 anoadragon453 merged commit 21c9e4d into dinsic Mar 16, 2020
@anoadragon453 anoadragon453 deleted the babolivier/dinsic_account_validity_condition branch March 16, 2020 11:32
anoadragon453 added a commit that referenced this pull request Mar 24, 2020
…nsic-release-v1.1.0

* 'dinsic' of github.com:matrix-org/synapse-dinsic:
  Fixes an attribute error when using the default display name during registration. (#32)
  Share SSL contexts for non-federation requests (#30)
  Share SSL options for well-known requests (#29)
  Fix buggy condition in account validity handler (#28)
anoadragon453 added a commit that referenced this pull request Mar 24, 2020
…nsic-release-v1.2.0

* 'dinsic' of github.com:matrix-org/synapse-dinsic:
  Fixes an attribute error when using the default display name during registration. (#32)
  Share SSL contexts for non-federation requests (#30)
  Share SSL options for well-known requests (#29)
  Fix buggy condition in account validity handler (#28)
anoadragon453 added a commit that referenced this pull request Mar 24, 2020
…nsic-release-v1.3.0

* 'dinsic' of github.com:matrix-org/synapse-dinsic:
  Fixes an attribute error when using the default display name during registration. (#32)
  Share SSL contexts for non-federation requests (#30)
  Share SSL options for well-known requests (#29)
  Fix buggy condition in account validity handler (#28)
anoadragon453 added a commit that referenced this pull request Mar 24, 2020
…nsic-release-v1.4.x

* 'dinsic' of github.com:matrix-org/synapse-dinsic:
  Fixes an attribute error when using the default display name during registration. (#32)
  Share SSL contexts for non-federation requests (#30)
  Share SSL options for well-known requests (#29)
  Fix buggy condition in account validity handler (#28)
anoadragon453 added a commit that referenced this pull request Mar 24, 2020
…nsic-release-v1.5.x

* 'dinsic' of github.com:matrix-org/synapse-dinsic:
  Fixes an attribute error when using the default display name during registration. (#32)
  Share SSL contexts for non-federation requests (#30)
  Share SSL options for well-known requests (#29)
  Fix buggy condition in account validity handler (#28)
anoadragon453 added a commit that referenced this pull request Mar 24, 2020
…nsic-release-v1.6.x

* 'dinsic' of github.com:matrix-org/synapse-dinsic:
  Fixes an attribute error when using the default display name during registration. (#32)
  Share SSL contexts for non-federation requests (#30)
  Share SSL options for well-known requests (#29)
  Fix buggy condition in account validity handler (#28)
anoadragon453 added a commit that referenced this pull request Mar 24, 2020
…nsic-release-v1.7.x

* 'dinsic' of github.com:matrix-org/synapse-dinsic:
  Fixes an attribute error when using the default display name during registration. (#32)
  Share SSL contexts for non-federation requests (#30)
  Share SSL options for well-known requests (#29)
  Fix buggy condition in account validity handler (#28)
anoadragon453 added a commit that referenced this pull request Mar 24, 2020
…nsic-release-v1.8.x

* 'dinsic' of github.com:matrix-org/synapse-dinsic:
  Fixes an attribute error when using the default display name during registration. (#32)
  Share SSL contexts for non-federation requests (#30)
  Share SSL options for well-known requests (#29)
  Fix buggy condition in account validity handler (#28)
anoadragon453 added a commit that referenced this pull request Mar 24, 2020
…nsic-release-v1.9.x

* 'dinsic' of github.com:matrix-org/synapse-dinsic:
  Fixes an attribute error when using the default display name during registration. (#32)
  Share SSL contexts for non-federation requests (#30)
  Share SSL options for well-known requests (#29)
  Fix buggy condition in account validity handler (#28)
anoadragon453 added a commit that referenced this pull request Mar 24, 2020
…nsic-release-v1.11.x

* 'dinsic' of github.com:matrix-org/synapse-dinsic:
  Fixes an attribute error when using the default display name during registration. (#32)
  Share SSL contexts for non-federation requests (#30)
  Share SSL options for well-known requests (#29)
  Fix buggy condition in account validity handler (#28)
anoadragon453 added a commit that referenced this pull request Mar 24, 2020
…nsic-release-v1.12.x

* 'dinsic' of github.com:matrix-org/synapse-dinsic:
  Fixes an attribute error when using the default display name during registration. (#32)
  Share SSL contexts for non-federation requests (#30)
  Share SSL options for well-known requests (#29)
  Fix buggy condition in account validity handler (#28)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants