This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Show knock rooms in the public room directory and inform clients they can be knocked on #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoadragon453
force-pushed
the
anoa/knock_public_rooms
branch
from
c06cf4b to
0a38e8f
Compare
anoadragon453
force-pushed
the
anoa/knock_public_rooms
branch
from
fcfe994 to
c50796d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the "Changes regarding the Public Rooms Directory" section of knocking MSC2403.
Specifically, it:
join_rule"knock" to be returned by the query behind the public rooms directoryjoin_ruleto each room entry returned by a public rooms directory query, so clients can know whether to attempt a join or knock on a roomThis PR is a clone of the mainline PR. Complement tests for this change: matrix-org/complement#72. I'm currently waiting for the Complement tests to merge before merging here.