Migrate to new module interface #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babolivier
force-pushed
the
babolivier/new_api
branch
from
80e0bc5
to
f3264be
Compare
babolivier
force-pushed
the
babolivier/new_api
branch
from
1c8fce8
to
f086863
Compare
richvdh
reviewed
Jul 26, 2021
richvdh
reviewed
Jul 26, 2021
richvdh
reviewed
Jul 26, 2021
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
babolivier
commented
Aug 4, 2021
babolivier
commented
Aug 4, 2021
richvdh
reviewed
Aug 4, 2021
| You can find and change the default templates [here](https://github.com/matrix-org/synapse-email-account-validity/tree/main/email_account_validity/templates). | ||
| Admins can install custom templates either by changing the default ones directly, or by | ||
| configuring Synapse with a custom template directory that contains the custom templates. | ||
| Admins that don't need to customise their templates can just use the module as is and ignore this paragraph. |
There was a problem hiding this comment.
ok, how does this work?
it looks like we call module_api.read_templates (with no custom template dir), which calls config._base.read_templates, which just looks in synapse/res/templates. How does it find templates in email_account_validity/templates?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out of #3