Fix joining rooms through aliases where the alias server isn't a real…

… homeserver (#15776)
matrix-org · Jun 14, 2023 · 1404f68 · 1404f68
1 parent 87e5df9
commit 1404f68
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/15776.bugfix b/changelog.d/15776.bugfix
@@ -0,0 +1 @@
+Fix joining rooms through aliases where the alias server isn't a real homeserver. Contributed by @tulir @ Beeper.
diff --git a/synapse/handlers/room_member.py b/synapse/handlers/room_member.py
@@ -1498,7 +1498,7 @@ async def lookup_room_alias(
         # put the server which owns the alias at the front of the server list.
         if room_alias.domain in servers:
             servers.remove(room_alias.domain)
-        servers.insert(0, room_alias.domain)
+            servers.insert(0, room_alias.domain)
 
         return RoomID.from_string(room_id), servers
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix joining rooms through aliases where the alias server isn't a real homeserver. Contributed by @tulir @ Beeper.