This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
If
global_factor
is omitted, use 0.5 on reload
Consider the following scenario: 1. Start synapse with config that omits a `caches.global_factor`. 2. `CacheProperties.default_factor_size` is now 0.5. 3. Edit config to set `caches.global_factor = 2`. 4. Reload config. 5. Read `CacheProperties.default_factor_size`. - Without patch: still 2 - With patch: backt to 0.5 Without this commit, when we reload config we will compute `self.global_factor` to be the _previous_ global cache factor. I think this is surprising: I would that factor to reflect what the config file says.
- Loading branch information