Fix requestOpenIdToken response: integer expires_in

`expires_in` must be an integer according to the OpenAPI spec: https://github.com/matrix-org/matrix-doc/blob/master/data/api/client-server/definitions/openid_token.yaml#L32 True division (`/`) returns a float instead (`"expires_in": 3600.0`). Floor division (`//`) returns an integer, so the response is spec compliant. Signed-off-by: Lukas Lihotzki <lukas@lihotzki.de>
matrix-org · Jun 14, 2021 · 2ab40f8 · 2ab40f8
1 parent 1dfdc87
commit 2ab40f8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/10175.bugfix b/changelog.d/10175.bugfix
@@ -0,0 +1 @@
+Return an integer `expires_in` in requestOpenIdToken response.
diff --git a/synapse/rest/client/v2_alpha/openid.py b/synapse/rest/client/v2_alpha/openid.py
@@ -85,7 +85,7 @@ async def on_POST(self, request, user_id):
                 "access_token": token,
                 "token_type": "Bearer",
                 "matrix_server_name": self.server_name,
-                "expires_in": self.EXPIRES_MS / 1000,
+                "expires_in": self.EXPIRES_MS // 1000,
             },
         )