Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Always build Rust extension in release mode (#14009)
Browse files Browse the repository at this point in the history
Fixes #13990
  • Loading branch information
erikjohnston authored Oct 3, 2022
1 parent 2769ef4 commit 343038c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions build_rust.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ def build(setup_kwargs: Dict[str, Any]) -> None:
path=cargo_toml_path,
binding=Binding.PyO3,
py_limited_api=True,
# We force always building in release mode, as we can't tell the
# difference between using `poetry` in development vs production.
debug=False,
)
setup_kwargs.setdefault("rust_extensions", []).append(extension)
setup_kwargs["zip_safe"] = False
1 change: 1 addition & 0 deletions changelog.d/14009.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix bug where Rust extension wasn't built in `release` mode when using `poetry install`.

0 comments on commit 343038c

Please sign in to comment.