Fix malformed log line in new federation "catch up" logic (#8442)

matrix-org · Oct 2, 2020 · 3bd3707 · 3bd3707
1 parent 61aaf36
commit 3bd3707
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/8442.bugfix b/changelog.d/8442.bugfix
@@ -0,0 +1 @@
+Fix malformed log line in new federation "catch up" logic.
diff --git a/synapse/federation/sender/per_destination_queue.py b/synapse/federation/sender/per_destination_queue.py
@@ -490,7 +490,7 @@ async def _catch_up_transmission_loop(self) -> None:
                 )
 
             if logger.isEnabledFor(logging.INFO):
-                rooms = (p.room_id for p in catchup_pdus)
+                rooms = [p.room_id for p in catchup_pdus]
                 logger.info("Catching up rooms to %s: %r", self._destination, rooms)
 
             success = await self._transaction_manager.send_new_transaction(
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix malformed log line in new federation "catch up" logic.