Fix a spec compliance issue where requests to the /publicRooms fede…

…ration API would specify `limit` as a string. (#12364)
matrix-org · Apr 5, 2022 · 42d8710 · 42d8710
1 parent 708d88b
commit 42d8710
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/changelog.d/12364.bugfix b/changelog.d/12364.bugfix
@@ -0,0 +1 @@
+Fix a spec compliance issue where requests to the `/publicRooms` federation API would specify `limit` as a string.
diff --git a/synapse/federation/transport/client.py b/synapse/federation/transport/client.py
@@ -481,7 +481,7 @@ async def get_public_rooms(
             if third_party_instance_id:
                 data["third_party_instance_id"] = third_party_instance_id
             if limit:
-                data["limit"] = str(limit)
+                data["limit"] = limit
             if since_token:
                 data["since"] = since_token
 
@@ -509,7 +509,7 @@ async def get_public_rooms(
             if third_party_instance_id:
                 args["third_party_instance_id"] = (third_party_instance_id,)
             if limit:
-                args["limit"] = [str(limit)]
+                args["limit"] = [limit]
             if since_token:
                 args["since"] = [since_token]