Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Disable validation that a UI authentication session has not been modi…
Browse files Browse the repository at this point in the history
…fied during a request cycle.

Partial backout of 1c1242a (#7068)
  • Loading branch information
clokep committed May 7, 2020
1 parent d9b8d27 commit 4d3ebc3
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions synapse/handlers/auth.py
Original file line number Diff line number Diff line change
Expand Up @@ -329,18 +329,6 @@ async def check_auth(
# isn't arbitrary.
clientdict = session.clientdict

# Ensure that the queried operation does not vary between stages of
# the UI authentication session. This is done by generating a stable
# comparator based on the URI, method, and body (minus the auth dict)
# and storing it during the initial query. Subsequent queries ensure
# that this comparator has not changed.
comparator = (uri, method, clientdict)
if (session.uri, session.method, session.clientdict) != comparator:
raise SynapseError(
403,
"Requested operation has changed during the UI authentication session.",
)

if not authdict:
raise InteractiveAuthIncompleteError(
self._auth_dict_for_flows(flows, session.session_id)
Expand Down

0 comments on commit 4d3ebc3

Please sign in to comment.