Limit concurrent event creation for a room to avoid state resolution …

…when sending bursts of events to a local room (#14977)
matrix-org · Feb 8, 2023 · 55e4d27 · 55e4d27
1 parent 975f7ba
commit 55e4d27
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/changelog.d/14977.misc b/changelog.d/14977.misc
@@ -0,0 +1 @@
+Limit concurrent event creation for a room to avoid state resolution when sending bursts of events to a local room.
diff --git a/synapse/handlers/message.py b/synapse/handlers/message.py
@@ -499,9 +499,9 @@ def __init__(self, hs: "HomeServer"):
 
         self.request_ratelimiter = hs.get_request_ratelimiter()
 
-        # We arbitrarily limit concurrent event creation for a room to 5.
-        # This is to stop us from diverging history *too* much.
-        self.limiter = Linearizer(max_count=5, name="room_event_creation_limit")
+        # We limit concurrent event creation for a room to 1. This prevents state resolution
+        # from occurring when sending bursts of events to a local room
+        self.limiter = Linearizer(max_count=1, name="room_event_creation_limit")
 
         self._bulk_push_rule_evaluator = hs.get_bulk_push_rule_evaluator()