Fixup get_room_max_token

matrix-org · Oct 6, 2020 · 6425f43 · 6425f43
1 parent 604e33f
commit 6425f43
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/synapse/storage/databases/main/stream.py b/synapse/storage/databases/main/stream.py
@@ -356,6 +356,14 @@ def get_room_min_stream_ordering(self) -> int:
         raise NotImplementedError()
 
     def get_room_max_token(self) -> RoomStreamToken:
+        """Get a `RoomStreamToken` that marks the current maximum persisted
+        position of the events stream. Useful to get a token that represents
+        "now".
+
+        The token returned is a "live" token that may have an instance_map
+        component.
+        """
+
         min_pos = self._stream_id_gen.get_current_token()
 
         positions = {}
@@ -372,9 +380,6 @@ def get_room_max_token(self) -> RoomStreamToken:
                 if p > min_pos
             }
 
-            if set(positions.values()) == {min_pos}:
-                positions = {}
-
         return RoomStreamToken(None, min_pos, positions)
 
     async def get_room_events_stream_for_rooms(