Replace TODO with issue #11152

matrix-org · Oct 21, 2021 · 768382e · 768382e
1 parent 4623514
commit 768382e
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 8 deletions.
diff --git a/synapse/handlers/receipts.py b/synapse/handlers/receipts.py
@@ -267,10 +267,6 @@ async def get_new_events_as(
         )
 
         # Then filter down to rooms that the AS can read
-        # TODO: This doesn't honour an appservice's registration of room or namespace
-        #   aliases. For instance, if an appservice registered a room namespace that
-        #   matched this room, but it didn't have any members in the room, then that
-        #   appservice wouldn't receive the read receipt.
         events = []
         for room_id, event in rooms_to_events.items():
             if not await service.matches_user_in_member_list(room_id, self.store):

diff --git a/synapse/handlers/typing.py b/synapse/handlers/typing.py
@@ -482,10 +482,6 @@ async def get_new_events_as(
                 if handler._room_serials[room_id] <= from_key:
                     continue
 
-                # TODO: This doesn't to honour an appservice's registration of room or namespace
-                #   aliases. For instance, if an appservice registered a room namespace that
-                #   matched this room, but it didn't have any members in the room, then that
-                #   appservice wouldn't receive the typing event.
                 if not await service.matches_user_in_member_list(
                     room_id, handler.store
                 ):