This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Upper-bound frozendict dependency (#15114)
* Upper-bound frozendict dependency This is an ugly kludge to solve #15109. It is not the most friendly thing to do for downstream packagers (apologies), but we are a) running low on time at the moment, and b) seeking to remove frozendict anyway. * Changelog
- Loading branch information
David Robertson
authored
Feb 21, 2023
1 parent
bb374f4
commit 8cede52
Showing
3 changed files
with
5 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Upper-bound frozendict dependency. This works around us being unable to test installing our wheels against Python 3.11 in CI. |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8cede52
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excuse me, I found this project for chance.
I want only to say that I removed all the problematic binaries from version 2.1.2, and in 2.3.5 I simply changed the C Extension to optional to support building from sdist. To make it mandatory you have now to put an env variable (documented).
If you contacted me I was very happy to support your project and explain the changes.
That said, immutabledict is a good project so, since you switched to it, I think there's no more to say.