Fix PeriodicallyFlushingMemoryHandler inhibiting application shutdown (…

…#10517)
matrix-org · Aug 3, 2021 · 903db99 · 903db99
1 parent 6878e10
commit 903db99
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/changelog.d/10517.bugfix b/changelog.d/10517.bugfix
@@ -0,0 +1 @@
+Fix the `PeriodicallyFlushingMemoryHandler` inhibiting application shutdown because of its background thread.
diff --git a/synapse/logging/handlers.py b/synapse/logging/handlers.py
@@ -45,6 +45,7 @@ def __init__(
         self._flushing_thread: Thread = Thread(
             name="PeriodicallyFlushingMemoryHandler flushing thread",
             target=self._flush_periodically,
+            daemon=True,
         )
         self._flushing_thread.start()
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix the `PeriodicallyFlushingMemoryHandler` inhibiting application shutdown because of its background thread.