fix dict reuse between _EventInternalMetadata instances

matrix-org · Feb 7, 2020 · 9594c24 · 9594c24
1 parent b70053a
commit 9594c24
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/synapse/events/__init__.py b/synapse/events/__init__.py
@@ -104,7 +104,9 @@ class _EventInternalMetadata(object):
     __slots__ = ["_dict"]
 
     def __init__(self, internal_metadata_dict: JsonDict):
-        self._dict = internal_metadata_dict
+        # we have to copy the dict, because it turns out that the same dict is
+        # reused. TODO: fix that
+        self._dict = dict(internal_metadata_dict)
 
     outlier = DictProperty("outlier")  # type: bool
     out_of_band_membership = DictProperty("out_of_band_membership")  # type: bool