Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
Signed-off-by: Dan Callahan <danc@element.io>
  • Loading branch information
callahad committed Apr 7, 2021
1 parent 30f5708 commit 9a26295
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ jobs:
- run: scripts-dev/check-newsfragment

lint-sdist:
if: ${{ contains(github.ref, 'release-') }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand All @@ -55,7 +54,7 @@ jobs:
- run: python setup.py sdist bdist_wheel
- uses: actions/upload-artifact@v2
with:
name: distributions
name: Python Distributions
path: dist/*

# Dummy step to gate other tests on without repeating the whole list
Expand Down Expand Up @@ -234,7 +233,7 @@ jobs:
uses: actions/upload-artifact@v2
if: ${{ always() }}
with:
name: Sytest Logs (${{ join(matrix.*, ', ') }})
name: Sytest Logs - ${{ job.status }} - (${{ join(matrix.*, ', ') }})
path: |
/logs/results.tap
/logs/**/*.log*
Expand Down Expand Up @@ -310,8 +309,9 @@ jobs:
- run: docker build -t matrixdotorg/synapse:latest -f docker/Dockerfile .
working-directory: synapse

# Build another Synapse image based on the latest release, but suitable
# for testing federation with the image built in the prior step.
# Build a ready-to-run Synapse image based on the initial image above.
# This new image includes a config file, keys for signing and TLS, and
# other settings to make it suitable for testing under Complement.
- run: docker build -t complement-synapse -f Synapse.Dockerfile .
working-directory: complement/dockerfiles

Expand Down

0 comments on commit 9a26295

Please sign in to comment.