Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Add test for ObservableDeferred's cancellation behaviour
Browse files Browse the repository at this point in the history
Signed-off-by: Sean Quah <seanq@element.io>
  • Loading branch information
Sean Quah committed Mar 3, 2022
1 parent a511a89 commit b1676c0
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 0 deletions.
1 change: 1 addition & 0 deletions changelog.d/12149.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add test for `ObservableDeferred`'s cancellation behaviour.
28 changes: 28 additions & 0 deletions tests/util/test_async_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,34 @@ def check_val(res, idx):
self.assertEqual(str(results[0].value), "gah!", "observer 1 errback result")
self.assertEqual(str(results[1].value), "gah!", "observer 2 errback result")

def test_cancellation(self):
"""Test that cancelling an observer does not affect other observers."""
origin_d: "Deferred[int]" = Deferred()
observable = ObservableDeferred(origin_d, consumeErrors=True)

observer1 = observable.observe()
observer2 = observable.observe()
observer3 = observable.observe()

self.assertFalse(observer1.called)
self.assertFalse(observer2.called)
self.assertFalse(observer3.called)

# cancel the second observer
observer2.cancel()
self.assertFalse(observer1.called)
self.failureResultOf(observer2, CancelledError)
self.assertFalse(observer3.called)

# other observers resolve as normal
origin_d.callback(123)
self.assertEqual(observer1.result, 123, "observer 1 callback result")
self.assertEqual(observer3.result, 123, "observer 3 callback result")

# additional observers resolve as normal
observer4 = observable.observe()
self.assertEqual(observer4.result, 123, "observer 4 callback result")


class TimeoutDeferredTest(TestCase):
def setUp(self):
Expand Down

0 comments on commit b1676c0

Please sign in to comment.