Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Add index to improve performance of the /timestamp_to_event endpoin…
Browse files Browse the repository at this point in the history
…t used for jumping to a specific date in the timeline of a room. (#14799)
  • Loading branch information
reivilibre authored Jan 11, 2023
1 parent 73f0978 commit d6bda5a
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 0 deletions.
1 change: 1 addition & 0 deletions changelog.d/14799.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add index to improve performance of the `/timestamp_to_event` endpoint used for jumping to a specific date in the timeline of a room.
12 changes: 12 additions & 0 deletions synapse/storage/databases/main/events_bg_updates.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ class _BackgroundUpdates:

EVENTS_POPULATE_STATE_KEY_REJECTIONS = "events_populate_state_key_rejections"

EVENTS_JUMP_TO_DATE_INDEX = "events_jump_to_date_index"


@attr.s(slots=True, frozen=True, auto_attribs=True)
class _CalculateChainCover:
Expand Down Expand Up @@ -260,6 +262,16 @@ def __init__(
self._background_events_populate_state_key_rejections,
)

# Add an index that would be useful for jumping to date using
# get_event_id_for_timestamp.
self.db_pool.updates.register_background_index_update(
_BackgroundUpdates.EVENTS_JUMP_TO_DATE_INDEX,
index_name="events_jump_to_date_idx",
table="events",
columns=["room_id", "origin_server_ts"],
where_clause="NOT outlier",
)

async def _background_reindex_fields_sender(
self, progress: JsonDict, batch_size: int
) -> int:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
/* Copyright 2023 The Matrix.org Foundation C.I.C
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

INSERT INTO background_updates (ordering, update_name, progress_json) VALUES
(7324, 'events_jump_to_date_index', '{}');

0 comments on commit d6bda5a

Please sign in to comment.