Remove superfluous room_memberships join from background update (#1…

…5733) Spawning from #15731
matrix-org · Jun 7, 2023 · e536f02 · e536f02
1 parent 195b6a2
commit e536f02
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/changelog.d/15733.misc b/changelog.d/15733.misc
@@ -0,0 +1 @@
+Remove superfluous `room_memberships` join from background update.
diff --git a/synapse/storage/databases/main/roommember.py b/synapse/storage/databases/main/roommember.py
@@ -1460,7 +1460,6 @@ def add_membership_profile_txn(txn: LoggingTransaction) -> int:
                 SELECT stream_ordering, event_id, events.room_id, event_json.json
                 FROM events
                 INNER JOIN event_json USING (event_id)
-                INNER JOIN room_memberships USING (event_id)
                 WHERE ? <= stream_ordering AND stream_ordering < ?
                 AND type = 'm.room.member'
                 ORDER BY stream_ordering DESC
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Remove superfluous `room_memberships` join from background update.