Avoid type annotation problems in prom-client (#11834)

matrix-org · Jan 26, 2022 · ffd8dba · ffd8dba
1 parent c360840
commit ffd8dba
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/changelog.d/11834.misc b/changelog.d/11834.misc
@@ -0,0 +1 @@
+Workaround a type annotation problem in `prometheus_client` 0.13.0.
diff --git a/synapse/python_dependencies.py b/synapse/python_dependencies.py
@@ -75,7 +75,8 @@
     "msgpack>=0.5.2",
     "phonenumbers>=8.2.0",
     # we use GaugeHistogramMetric, which was added in prom-client 0.4.0.
-    "prometheus_client>=0.4.0",
+    # 0.13.0 has an incorrect type annotation, see #11832.
+    "prometheus_client>=0.4.0,<0.13.0",
     # we use `order`, which arrived in attrs 19.2.0.
     # Note: 21.1.0 broke `/sync`, see #9936
     "attrs>=19.2.0,!=21.1.0",