Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

invite rejections are not sent over federation #10222

Closed
richvdh opened this issue Jun 21, 2021 · 2 comments · Fixed by #10223
Closed

invite rejections are not sent over federation #10222

richvdh opened this issue Jun 21, 2021 · 2 comments · Fixed by #10223
Labels
S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@richvdh
Copy link
Member

richvdh commented Jun 21, 2021

Suppose:

  • A and B are in a room (each on a different homeserver)
  • A invites C (on a third homeserver)
  • C rejects the invite (and thus sends a leave event via send_leave to A)

The invite rejection should be sent out over federation to B, but this does not take place.
@richvdh
Copy link
Member Author

richvdh commented Jun 21, 2021

This tends to resolve itself fairly quickly because as soon as A sends another event, the other homeservers will pull in the missing leave via get_missing_events. But still, it's messy.

richvdh added a commit that referenced this issue Jun 21, 2021
@richvdh
Send out invite rejections over federation
37e2a3b 
ensure that leave events sent via `send_leave` are sent on to the rest of the
federation.

Fixes #10222.
@richvdh richvdh mentioned this issue Jun 21, 2021
Merged
@ShadowJonathan
Copy link
Contributor

Thought: isn't this essentially some form of partial mesh routing?

@erikjohnston erikjohnston added S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Jun 21, 2021
@richvdh richvdh mentioned this issue Jun 21, 2021
Merged
richvdh added a commit that referenced this issue Jun 21, 2021
@richvdh
Send out invite rejections over federation
971adec 
ensure that leave events sent via `send_leave` are sent on to the rest of the
federation.

Fixes #10222.
richvdh added a commit to matrix-org/complement that referenced this issue Jul 12, 2021
@richvdh
Test that knocks and invite rejections are sent out correctly over fe…
e354e62 
…deration (#131)

This is a regression test for matrix-org/synapse#10222, and also extends the knock tests to ensure we don't do the same thing there.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Send out invite rejections and knocks over federation matrix-org/synapse
3 participants
@richvdh @erikjohnston @ShadowJonathan