This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Historical state events from state_events_at_start in the MSC2716 /batch_send endpoint get pushed to an application service /transactions
#11241
Assignees
Labels
A-Application-Service
Related to AS support
T-Defect
Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Comments
MadLittleMods
added
the
T-Defect
|
From my testing, the historical state does not come down Need to dig into the application service being pushed historical state events on I just assumed it would be a problem on incremental |
MadLittleMods
added a commit
that referenced
this issue
Nov 5, 2021
4 tasks
MadLittleMods
added a commit
to matrix-org/complement
that referenced
this issue
Nov 6, 2021
Regression tests for matrix-org/synapse#11241 Synapse changes: matrix-org/synapse#11265
MadLittleMods
changed the title
state_events_at_start in the MSC2716 /batch_send endpoint come down /sync and /transactionsstate_events_at_start in the MSC2716 /batch_send endpoint get pushed to an application service /transactions
MadLittleMods
added a commit
that referenced
this issue
Nov 18, 2021
…via `/transactions` (MSC2716) (#11265) Mark historical state from the MSC2716 `/batch_send` endpoint as `historical` which makes it `backfilled` and have a negative `stream_ordering` so it doesn't get queried by `/transactions`. Fix #11241 Complement tests: matrix-org/complement#221
MadLittleMods
added a commit
to matrix-org/complement
that referenced
this issue
Nov 23, 2021
Part of MSC2716: matrix-org/matrix-spec-proposals#2716 Related to matrix-org/synapse#11241 Split off from #221
MadLittleMods
added a commit
to matrix-org/complement
that referenced
this issue
Nov 24, 2021
…#235) Part of MSC2716: matrix-org/matrix-spec-proposals#2716 Related to matrix-org/synapse#11241 Split off from #221
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
As discovered by @tulir, when using the MSC2716
/batch_sendendpoint, events specified instate_events_at_startwill come downincrementaland the application services/sync/transactionsendpoints. Since this is historical state, it shouldn't be coming down the live pipe.We already have a Complement tests to ensure the historical messages don't come down incremental sync, but we should also do the same for the state events.
Relevant code
state_events_at_start:synapse/handlers/room_batch.py#L213-L249builder.internal_metadata.historical = True:synapse/handlers/message.py#L608backfilled = True:synapse/handlers/message.py#L1526-L1530The text was updated successfully, but these errors were encountered: