Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Enable dependabot updates #11828

Closed
GoliathLabs opened this issue Jan 25, 2022 · 4 comments · Fixed by #13976
Closed

Enable dependabot updates #11828

GoliathLabs opened this issue Jan 25, 2022 · 4 comments · Fixed by #13976
Labels
A-Packaging Our Debian packages, docker images; or issues relevant to downstream packagers O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@GoliathLabs
Copy link

Description:
I already use Dependabot for many projects. With Dependabot it is relatively easy to stay up to date with the dependencies and packages used. Instead of always checking for updates manually, you can e.g. use the dependabot.yml configuration to tell Dependabot to check the project once a week for new releases of the Python packages that are used. If there are new updates, a new pull request is automatically created for them.

Since this procedure takes at least some work off my hands over at my projects, I wanted to ask if you would be up to using it as well. The configuration file is quickly created and dependabot then runs without further ado.

@DMRobertson DMRobertson added the z-blocked (Deprecated Label) label Jan 26, 2022
@DMRobertson
Copy link
Contributor

We would like to take advantage of Dependabot, but the first order of business is to use a dependency specification and formal lockfile: #11537.

@GoliathLabs
Copy link
Author

@DMRobertson Okay, good to know. Thanks for the quick response

@DMRobertson DMRobertson added P2 T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. labels Jan 27, 2022
@DMRobertson
Copy link
Contributor

We have dependabot PRing security updates now that we use locked dependencies.

Next steps would be to

  • decide if we (@matrix-org/synapse-core) want to use dependabot for non-security upgrades
  • if so, configure it to do so.

Last time we talked about this I think there was general agreement this was probably worthwhile? We already test against latest deps in CI and this pulls in useful bugfixes (e.g. recent frozendict memory leak fixes.)

@DMRobertson DMRobertson added A-Packaging Our Debian packages, docker images; or issues relevant to downstream packagers S-Tolerable Minor significance, cosmetic issues, low or no impact to users. O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed z-blocked (Deprecated Label) P2 labels Aug 30, 2022
@GoliathLabs
Copy link
Author

@DMRobertson Good to hear. Dependabot can be configured quite easily (see: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/customizing-dependency-updates).

For myself, Dependabot takes some of the work off my hands as it keeps track of (non-)security upgrades and notifies me once a month (can be configured as desired). For larger projects or organizations this could be done daily or weekly (see: https://github.com/cinnyapp/cinny/blob/dev/.github/dependabot.yml)

DMRobertson pushed a commit that referenced this issue Sep 29, 2022
This claims to fix more memory leaks.

Could have automated this upgrade with #11828 if we wanted.
richvdh added a commit that referenced this issue Sep 30, 2022
richvdh added a commit that referenced this issue Sep 30, 2022
@richvdh richvdh changed the title Adding dependabot Enable dependabot updates Sep 30, 2022
richvdh added a commit that referenced this issue Sep 30, 2022
DMRobertson pushed a commit that referenced this issue Oct 7, 2022
* Update frozendict 2.3.3 -> 2.3.4

This claims to fix more memory leaks.

Could have automated this upgrade with #11828 if we wanted.

* Changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Packaging Our Debian packages, docker images; or issues relevant to downstream packagers O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants