Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

RC versions of dependencies don't satisfy the run-time dependency checker; Need Twisted>=18.9.0, but got Twisted==21.7.0rc3 (1.54.0rc1 suspected regression) #12176

Closed
reivilibre opened this issue Mar 8, 2022 · 1 comment · Fixed by #12177
Closed

RC versions of dependencies don't satisfy the run-time dependency checker; Need Twisted>=18.9.0, but got Twisted==21.7.0rc3 (1.54.0rc1 suspected regression) #12176

reivilibre opened this issue Mar 8, 2022 · 1 comment · Fixed by #12177
Assignees
@reivilibre
Labels
X-Regression Something broke which worked on a previous release X-Release-Blocker Must be resolved before making a release

Comments

@reivilibre
Copy link
Contributor

When deploying 1.54.0rc1 to matrix.org and some personal homeservers that had an RC of Twisted installed, the dependency checker complained:

Need Twisted>=18.9.0, but got Twisted==21.7.0rc3

For some reason it appears that being an RC makes the version insufficient, even though the version is higher. Using the non-RC version works fine.

Possibly fall-out from #12088?

I wonder if the same logic as e.g. pip is being used, in that it would never select an RC version as being satisfactory unless it was a hard match?
@reivilibre reivilibre added X-Release-Blocker Must be resolved before making a release X-Regression Something broke which worked on a previous release labels Mar 8, 2022
@reivilibre reivilibre self-assigned this Mar 8, 2022
@reivilibre reivilibre mentioned this issue Mar 8, 2022
Merged
reivilibre added a commit that referenced this issue Mar 8, 2022
@reivilibre
Add failing test to characterise the regression #12176
343bc6d
reivilibre added a commit that referenced this issue Mar 8, 2022
@reivilibre
Fix a bug introduced in 1.54.0rc1 which meant that Synapse would refu…
2eef234 
…se to start if pre-release versions of dependencies were installed. (#12177)

* Add failing test to characterise the regression #12176

* Permit pre-release versions of specified packages

* Newsfile (bugfix)

Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
@H-Shay
Copy link
Contributor

H-Shay commented Mar 9, 2022

Since the fix to this has merged I am going to close this issue.

@H-Shay H-Shay closed this as completed Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@reivilibre reivilibre

Labels
X-Regression Something broke which worked on a previous release X-Release-Blocker Must be resolved before making a release
Projects
None yet
Milestone
No milestone
2 participants
@H-Shay @reivilibre