Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

CI run against latest deps is failing #12626

Closed
github-actions bot opened this issue May 4, 2022 · 5 comments
Closed

CI run against latest deps is failing #12626

github-actions bot opened this issue May 4, 2022 · 5 comments
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022 •
edited
Loading

See https://github.com/matrix-org/synapse/actions/runs/2274165918
@DMRobertson DMRobertson self-assigned this May 4, 2022
@DMRobertson
Copy link
Contributor

Maybe a casualty of #12608?

@DMRobertson
Copy link
Contributor

setup-python-poetry removes the extras??

Run poetry install --no-interaction
Installing dependencies from lock file
Warning: poetry.lock is not consistent with pyproject.toml. You may be getting improper dependencies. Run `poetry lock [--no-update]` to fix it.

Package operations: 0 installs, 0 updates, 19 removals

  • Removing authlib (0.15.5)
  • Removing defusedxml (0.7.1)
  • Removing elementpath (2.5.0)
  • Removing hiredis (2.0.0)
  • Removing jaeger-client (4.8.0)
  • Removing ldap3 (2.9.1)
  • Removing lxml (4.8.0)
  • Removing matrix-synapse-ldap3 (0.2.0)
  • Removing opentracing (2.4.0)
  • Removing psycopg2 (2.9.3)
  • Removing pysaml2 (7.1.2)
  • Removing python-dateutil (2.8.2)
  • Removing pytz (2021.3)
  • Removing sentry-sdk (1.5.7)
  • Removing threadloop (1.0.2)
  • Removing thrift (0.15.0)
  • Removing tornado (6.1)
  • Removing txredisapi (1.4.7)
  • Removing xmlschema (1.10.0)

And nothing happens to undo this in the poetry install --no-interaction later on. Is this a quirk of the poetry 1.2 beta? GRR

@DMRobertson
Copy link
Contributor

Warning: poetry.lock is not consistent with pyproject.toml. You may be getting improper dependencies. Run poetry lock [--no-update] to fix it.

It seems that poetry 1.2 now wants to pin versions of setuptools in the lockfile. Guessing that python-poetry/poetry#2826 is the change.

@DMRobertson
Copy link
Contributor

Poetry 1.2.0b1 will now remove extras that you've previously installed, but haven't specified on a second invocation of poetry install. (Which sounds like it merits a major semver bump to me!!) I would guess python-poetry/poetry#2826 is the relevant change.

DMRobertson pushed a commit to matrix-org/setup-python-poetry that referenced this issue May 4, 2022
Install deps and project in one go
f67eafb 
This works around a change in poetry 1.2; see explanation here:
matrix-org/synapse#12626 (comment)

I had originally made the "install deps" and "install project" steps
separate, to allow us to skip the installing deps bit if there was a
cache hit. Maintaining that approach would now be painful because I'd
need two different `poetry install` invocations: one with extras and one
without. And it only saved us 1 or 2 seconds per run.
DMRobertson pushed a commit that referenced this issue May 4, 2022
Test fix for #12626
3630220
@DMRobertson DMRobertson mentioned this issue May 4, 2022
Merged
@anoadragon453 anoadragon453 added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label May 5, 2022
@DMRobertson
Copy link
Contributor

I believe this should be fixed by matrix-org/setup-python-poetry#4. If not, we'll find out tomorrow.

@DMRobertson DMRobertson removed their assignment May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anoadragon453 @DMRobertson