Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Invites push actions don't get persisted and can't be queried using /notifications if the user doesn't have any pusher registered #12839

Closed
deepbluev7 opened this issue May 23, 2022 · 2 comments · Fixed by #12840
Closed

Invites push actions don't get persisted and can't be queried using /notifications if the user doesn't have any pusher registered #12839

deepbluev7 opened this issue May 23, 2022 · 2 comments · Fixed by #12840
Labels
S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@deepbluev7
Copy link
Contributor

Description

For invites there exists a special push rule: .m.rule.invite_for_me. This rule seems to never get evaluated and added to the event_push_actions table, which then causes /notifications to never return pending invites as notifications.

Steps to reproduce

  • Invite another user
  • Search for the invite using the following query: SELECT * FROM event_push_actions WHERE event_id = '$event'

I would like invites to actually show up as notifications!

Version information

  • Homeserver: neko.dev

If not matrix.org:

  • Version: 1.59.1

  • Install method: ebuild

  • Platform: Gentoo
@deepbluev7
Copy link
Contributor Author

I guess that is explicitly disabled for some reason?!?

synapse/synapse/push/bulk_push_rule_evaluator.py

Line 149 in 116a4c8

has_pusher = await self.store.user_has_pusher(invited)

deepbluev7 added a commit to deepbluev7/synapse that referenced this issue May 23, 2022
@deepbluev7
Fix invite notifications for users without pushers
4bccc7a 
fixes matrix-org#12839

Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
@deepbluev7 deepbluev7 mentioned this issue May 23, 2022
Merged
4 tasks
@babolivier babolivier changed the title Invites push actions don't get persisted and can't be queried using /notifications Invites push actions don't get persisted and can't be queried using /notifications if the user doesn't have any pusher registered May 23, 2022
@babolivier
Copy link
Contributor

babolivier commented May 23, 2022 •
edited by clokep
Loading

For the paper trail, this bug was introduced in ed3979d

@babolivier babolivier added S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix invite notifications for users without pushers deepbluev7/synapse
2 participants
@babolivier @deepbluev7