Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

retention comes with insufficient warnings #13475

Closed
richvdh opened this issue Aug 8, 2022 · 5 comments · Fixed by #13497
Closed

retention comes with insufficient warnings #13475

richvdh opened this issue Aug 8, 2022 · 5 comments · Fixed by #13497
Assignees
Labels
A-Docs things relating to the documentation T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution

Comments

@richvdh
Copy link
Member

richvdh commented Aug 8, 2022

it is well-known to corrupt the database via insufficient cache invalidation, yet the config documentation almost recommends it. It needs a big health warning

@richvdh richvdh added the A-Docs things relating to the documentation label Aug 8, 2022
@richvdh
Copy link
Member Author

richvdh commented Aug 8, 2022

cf #13476

@4nd3r
Copy link
Contributor

4nd3r commented Aug 8, 2022

What happens if I decide (because of mentioned risk) to remove retention: enabled: true from configuration and many rooms in my HS have retention configured? Is it safe? Please add that to docs also.

@dklimpel
Copy link
Contributor

dklimpel commented Aug 8, 2022

And are there different risks if I delete history e.g. from yesterday or 3 years ago?

@richvdh
Copy link
Member Author

richvdh commented Aug 8, 2022

What happens if I decide (because of mentioned risk) to remove retention: enabled: true from configuration and many rooms in my HS have retention configured? Is it safe?

I believe that's fine, yes.

Please add that to docs also.

Pull requests to improve the documentation are always welcome 😇

@richvdh richvdh added the Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution label Aug 8, 2022
@richvdh
Copy link
Member Author

richvdh commented Aug 8, 2022

And are there different risks if I delete history e.g. from yesterday or 3 years ago?

Yes, there are different risks in the sense that you're less likely to hit one of the problematic races by deleting history from 3 years ago than by deleting history from yesterday.

@H-Shay H-Shay self-assigned this Aug 10, 2022
@H-Shay H-Shay added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Aug 10, 2022
DMRobertson pushed a commit that referenced this issue Aug 3, 2023
No really, don't use it.

Follow up to #13475, #13497.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Docs things relating to the documentation T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution
Projects
None yet
4 participants