Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Synapse uses deprecated keyId path param on /_matrix/key/v2/server #14523

Closed
richvdh opened this issue Nov 22, 2022 · 3 comments · Fixed by #14525
Closed

Synapse uses deprecated keyId path param on /_matrix/key/v2/server #14523

richvdh opened this issue Nov 22, 2022 · 3 comments · Fixed by #14525
Assignees
@richvdh
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. Z-Cleanup Things we want to get rid of, but aren't actively causing pain

Comments

@richvdh
Copy link
Member

richvdh commented Nov 22, 2022

The spec has deprecated the keyId parameter on GET /_matrix/key/v2/server since forever.

(The reason given for that deprecation was that it is ignored on the server side.)
@richvdh richvdh self-assigned this Nov 22, 2022
@DMRobertson
Copy link
Contributor

DMRobertson commented Nov 22, 2022 •
edited
Loading

Supercedes #14488, I suppose.

(Didn't we discuss this and we thought that Synapse was behaving correctly in making these requests? Perhaps we were just mistaken?)

@richvdh
Copy link
Member Author

richvdh commented Nov 22, 2022

yes, we were mistaken. Sorry, I got confused :/

@richvdh richvdh mentioned this issue Nov 22, 2022
Merged
@DMRobertson
Copy link
Contributor

No worries, just wanted to double check! 👍

@DMRobertson DMRobertson added S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience O-Uncommon Most users are unlikely to come across this or unexpected workflow Z-Cleanup Things we want to get rid of, but aren't actively causing pain and removed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Nov 22, 2022
richvdh added a commit that referenced this issue Nov 30, 2022
@richvdh
Stop using deprecated keyIds param on /key/v2/server (#14525)
ecb6fe9 
Fixes #14523.
H-Shay pushed a commit that referenced this issue Dec 13, 2022
@richvdh @H-Shay
Stop using deprecated keyIds param on /key/v2/server (#14525)
aa389ed 
Fixes #14523.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@richvdh richvdh

Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. Z-Cleanup Things we want to get rid of, but aren't actively causing pain
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop using deprecated keyIds param on /key/v2/server matrix-org/synapse
2 participants
@richvdh @DMRobertson