Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Split account_threepid_handler into a msisdn and email versions #5928

Closed
anoadragon453 opened this issue Aug 28, 2019 · 1 comment
Closed
Assignees
Labels
z-privacy-sprint (Deprecated Label)

Comments

@anoadragon453
Copy link
Member

We realized we could run into an issue where because Synapse can't support sending SMS yet, you may find yourself wanting to use Synapse to send password reset emails, but then can't support msisdn registration.

We need to split up account_threepid_handler into msisdn and email versions so that people can configure these things separately.

On the backend side, this will involve:

  • Updating UPGRADE.rst and other various changelog notes
  • Updating the requires_identity_server unstable /versions flag to have an email and msisdn version, so clients know what to do for each
  • Updating the account_threepid_handler config option and creating two, and updating all the checks to either be based off the msisdn or the email version
@anoadragon453 anoadragon453 self-assigned this Aug 28, 2019
anoadragon453 added a commit that referenced this issue Sep 5, 2019
…erification (#5940)

Fixes: #5751
Fixes: #5928

#5835 allowed Synapse to send registration emails to the user. Now we need to accept them and have it succeed the `m.login.email.identity` registration flow step.

`account_threepid_handler` will also be switched from a `str` in the config file to a dictionary which contains entries for `msisdn` and `email`, each with their own `str`. This will let people use an external server to handle `msisdn` registration and password reset requests, while using Synapse for email-based things.

And the `password_servlet` hack that was introduced in https://github.com/matrix-org/synapse/pull/5377/files#diff-b8464485d36f6f87caee3f4d82524213R189 to distinguish a registration call from a password reset call will be removed.
@anoadragon453
Copy link
Member Author

Done in #5940

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
z-privacy-sprint (Deprecated Label)
Projects
None yet
Development

No branches or pull requests

1 participant