Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

v1.4.1: Remember to drop unused tables #6048

Closed
richvdh opened this issue Sep 18, 2019 · 1 comment
Closed

v1.4.1: Remember to drop unused tables #6048

richvdh opened this issue Sep 18, 2019 · 1 comment

Comments

@richvdh
Copy link
Member

richvdh commented Sep 18, 2019

#5893 dropped four tables (room_names, topics, history_visibility, guest_access) from the database schema, but #6047 reinstated them. We should remember to re-redelete them.

Note that there will exist servers which got upgraded to develop and will have already run the delta file, and hence dropped the tables, so any future delta which re-drops them should bear this in mind. This will be WAY EASIER if we can do it before the database schema version bumps up to 57 so that we can just reinstate the old delta.

richvdh added a commit that referenced this issue Sep 26, 2019
These tables are unused since #5893 (as amended by #6047), so we can now drop
them.

Fixes #6048.
richvdh added a commit that referenced this issue Sep 30, 2019
These tables are unused since #5893 (as amended by #6047), so we can now drop
them.

Fixes #6048.
@richvdh
Copy link
Member Author

richvdh commented Sep 30, 2019

done in #6115

@richvdh richvdh closed this as completed Sep 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants